Optimized Compress-Folder and removed New-Folder#952
Conversation
Didn't need this as we can use New-Item -Force to handle everything that New-Folder basically was. Only losing the fact that we don't call Write-Host, but this isn't required.
Removed some of the old code that didn't need to be there.
| Write-Verbose("Creating script block") | ||
| $newFolderScriptBlock = [scriptblock]::Create($newFolderString) | ||
| Write-Verbose("New-Item create Script Block") | ||
| # need to have a blank param to be able to pass an array of 2 folders. |
There was a problem hiding this comment.
What's this for? It looks like you can pass multiple paths directly:
There was a problem hiding this comment.
For remote execution at the same time within Start-JobManager.
The paths that we need to create are something like this:
Start-JobManager is able to kick off multiple jobs against each server and have unique arguments being passed to each server.
There was a problem hiding this comment.
I still don't follow. If you want to pass multiple paths:
The blank parameter is not needed.
There was a problem hiding this comment.
After testing it out, I remove the $blank parameter and it does still work but do need to have a fake secondary parameter to pass to the caller. Similar to what you have in the snapshot above. Otherwise, Invoke-Command doesn't know that the array paths need to be going to the 1st parameter. Instead, it would do 1 path to the first parameter, then the second path to the second parameter which doesn't exist and only one path is created.
Use the , instead of a unused parameter to avoid the array from getting unwrapped when passed to the argument list of Invoke-Command.
2 participants
Reason:
Cleaned up the code on Compress-Folder that wasn't needed.
Removed New-Folder as what it was doing could be handled by New-Item with the Force switch.
Validation:
Tested out in lab.