Skip to content

Thestarslayer defineword#66

Merged
niels9001 merged 6 commits into
microsoft:mainfrom
TheStarSlayer:thestarslayer-defineword
Apr 28, 2026
Merged

Thestarslayer defineword#66
niels9001 merged 6 commits into
microsoft:mainfrom
TheStarSlayer:thestarslayer-defineword

Conversation

@TheStarSlayer
Copy link
Copy Markdown
Contributor

@TheStarSlayer TheStarSlayer commented Apr 27, 2026

Extension Submission

Thanks for submitting your extension to the Command Palette Extensions Gallery!
Please fill out the checklist below to help us review your PR quickly.

Checklist

  • My folder follows the <author>/<extension-name> convention (lowercase, alphanumeric + hyphens only)
  • I have added an extension.json with all required fields
  • The id field in my extension.json matches my folder path (author.extension-name)
  • I have added an icon file (PNG or SVG, under 100 KB)
  • The icon field in extension.json matches my icon filename
  • My extension is available at the install source I specified (winget/MS Store/URL)
  • I have read the Contributing Guide

@TheStarSlayer
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

Copy link
Copy Markdown
Contributor

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment

Comment thread extensions/thestarslayer/define-word-extension/extension.json Outdated
@niels9001
Copy link
Copy Markdown
Contributor

From CI:

❌ thestarslayer/define-word-extension/icon.png: Icon is 366.2 KB, exceeds 100 KB limit

Can you resize the icon file so it's smaller and meets the 100kb limit?

@TheStarSlayer
Copy link
Copy Markdown
Contributor Author

https://github.com/microsoft/CmdPal-Extensions/blob/main/docs/CONTRIBUTING.md#5-add-an-icon

In the checklist, it says PNG or SVG type image for icon; however, in contributing guide, it was specifically stated that SVG has no support.

@niels9001
Copy link
Copy Markdown
Contributor

https://github.com/microsoft/CmdPal-Extensions/blob/main/docs/CONTRIBUTING.md#5-add-an-icon

In the checklist, it says PNG or SVG type image for icon; however, in contributing guide, it was specifically stated that SVG has no support.

Great catch, yeah we inititally had svg support but that resulted in issues. We'll adjust the checklist. Thanks for reporting!

@niels9001 niels9001 merged commit 70b4326 into microsoft:main Apr 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants