Skip to content

fix: update OIDC FIC subjects to match org-level custom claim template; bump action versions#525

Merged
MikeWedderburn-Clarke merged 1 commit intomainfrom
copilot/fix-nightly-build-deploy
Apr 12, 2026
Merged

fix: update OIDC FIC subjects to match org-level custom claim template; bump action versions#525
MikeWedderburn-Clarke merged 1 commit intomainfrom
copilot/fix-nightly-build-deploy

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 12, 2026

Nightly Build & Deploy fails at Azure OIDC login — the Microsoft GitHub org now uses a customised OIDC subject claim template (repository_owner_id:ID:repository_id:ID:...) but the Bicep FICs were still configured with the old repo:org/repo:... format.

OIDC FIC subject format

  • Replace githubOrg/githubRepo string params with githubOwnerId/githubRepoId numeric ID params across managed-identity.bicep and main.bicep
  • FIC subjects now use repository_owner_id:${githubOwnerId}:repository_id:${githubRepoId}:environment:${env} (and :ref:refs/heads/main for the staging main-branch FIC)
  • nightly.yml deploy step passes ${{ github.repository_owner_id }} and ${{ github.repository_id }}
subject: 'repository_owner_id:${githubOwnerId}:repository_id:${githubRepoId}:environment:${environmentName}'

Action version bumps (Node.js 20 deprecation)

  • actions/checkout v4 → v5
  • actions/setup-node v4 → v5
  • azure/login v2 → v3

Applied across ci.yml, deploy.yml, and nightly.yml.

⚠️ Bootstrap note

First run post-merge will still fail at build-and-push because the Azure FIC update happens in the downstream deploy job. One-time manual FIC update required:

az identity federated-credential update \
  --name "github-actions-env-nightly" \
  --identity-name "id-acroyoga-nightly" \
  --resource-group "rg-acroyoga-nightly" \
  --subject "repository_owner_id:6154722:repository_id:1182392763:environment:nightly"

Subsequent Bicep deployments will self-maintain the correct format.

…d bump action versions

- Update managed-identity.bicep FIC subjects from repo:org/repo format
  to repository_owner_id:ID:repository_id:ID format matching the
  org-level OIDC subject claim template
- Replace githubOrg/githubRepo params with githubOwnerId/githubRepoId
  in managed-identity.bicep and main.bicep
- Update nightly.yml deploy step to pass github.repository_owner_id
  and github.repository_id context variables
- Bump actions/checkout v4→v5, actions/setup-node v4→v5, azure/login v2→v3
  to resolve Node.js 20 deprecation warnings
- Update spec docs (quickstart, data-model, infrastructure contract)

Agent-Logs-Url: https://github.com/microsoft/CommunityManagement-Sample-Spec-Kit/sessions/697e147e-72e0-48fe-b468-33c85317e72a

Co-authored-by: MikeWedderburn-Clarke <5323631+MikeWedderburn-Clarke@users.noreply.github.com>
@MikeWedderburn-Clarke MikeWedderburn-Clarke marked this pull request as ready for review April 12, 2026 18:59
@MikeWedderburn-Clarke MikeWedderburn-Clarke merged commit ccc2c5b into main Apr 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants