fix: merging dev to main #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vity feat: process KM sample data manually as part of post-deployment activity
fix: disable purge protection of key vault
fix: azure yaml provision issue
…ledge-Mining-Solution-Accelerator into fix/error-analyzer-path-not-found
…ployment with fallback to resource group location
fix: Ensure the environment setup script runs after the container starts
fix: Replace Hardcoded Secrets with Azure Key Vault References
Roopan-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Vinay-Microsoft,
aniaroramsft and
brittneek
as code owners
fix: Use converted Secure string access token in Invoke-Sqlcmd
fix: Downmerge from main to dev
…edge-Mining-Solution-Accelerator into feature/add-opentelemetry-logs
feat: add open telemetry logs
…er-data fix: internal server error in fetch apis
Prajwal-Microsoft
approved these changes
May 22, 2025
Contributor
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Environment Setup Improvements:
postStartCommandin.devcontainer/devcontainer.jsonwith a new script (setup_env.sh) for better modularity and maintainability. The script handles tasks such as pulling the latest code and setting execute permissions for scripts. [1] [2]Naming Convention Enhancements:
abbreviations.jsonfile to standardize and centralize naming conventions for various Azure resources. This replaces hardcoded naming patterns in deployment files.infra/deploy_ai_foundry.bicepto dynamically generate resource names using abbreviations fromabbreviations.json.Deployment Configuration Flexibility:
solutionLocationparameter across multiple deployment files (deploy_app_service.bicep,deploy_app_service_plan.bicep,deploy_backend_docker.bicep,deploy_frontend_docker.bicep, etc.) to allow specifying custom deployment locations instead of defaulting to the resource group location. [1] [2] [3] [4] [5]infra/deploy_cosmos_db.bicep,infra/deploy_keyvault.bicep,infra/deploy_managed_identity.bicep). [1] [2] [3]Key Vault Enhancements:
infra/deploy_backend_docker.bicepto grant the app service access to secrets stored in Key Vault.These changes collectively improve the modularity, maintainability, and flexibility of the deployment infrastructure.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information