Fix mismatched values and duplicate variable in RequestTimeOff topic#501
Merged
Merged
Conversation
Skantha
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix mismatched values and duplicate variable in RequestTimeOff topic
Fixes three issues in
WorkdayEmployeeRequestTimeOff/topic.yaml:Remove duplicate
TimeOffReasonConfigvariable —Topic.TimeOffReasonConfigwas declared twice. The first (unused) declaration withTitle/ReasonID/TimeOffTypeIDcolumns was removed, keeping the second one withReasonKey/TimeOffTypeID/ReasonIDcolumns thatresolve_reason_idactually uses viaLookUp.Fix
LeaveTypeConfigvalues to match dropdown choices — The keyword-to-leave-type mapping usedVacation_HoursandFloating_Holiday_Hours, but the adaptive card dropdown usesESS_Vacation_HoursandESS_Floating_Holiday_Hours. This caused auto-mapping from user input to never pre-select Vacation or Floating Holiday in the form.Fix success card
Switchto match actualtimeOffTypevalues — The confirmation card's type-of-leave display used stale values (Vacation_Hours,Floating_Holiday_Hours,Sick Leave) that didn't match the dropdown values. Updated toESS_Vacation_Hours,ESS_Floating_Holiday_Hours,ESS_Sick_Time_Off, and added the missingESS_Comp_Off→ "Comp off" case.