Skip to content

Remove Workday-branded header from EmployeeUpdateResidentialAddress cards#508

Merged
AdwaitRaut merged 2 commits into
microsoft:mainfrom
AdwaitRaut:remove-workday-card-branding
May 8, 2026
Merged

Remove Workday-branded header from EmployeeUpdateResidentialAddress cards#508
AdwaitRaut merged 2 commits into
microsoft:mainfrom
AdwaitRaut:remove-workday-card-branding

Conversation

@AdwaitRaut
Copy link
Copy Markdown
Contributor

Summary

  • Strips the ColumnSet header (Workday icon + "Workday" label) from both adaptive cards in EmployeeUpdateResidentialAddress/topic.yaml:
    • the address-selection card (selectAddressCard)
    • the success-confirmation card sent after Topic.updateIsSuccess = true
  • Removes the set_workday_icon_url SetVariable that held the inline base64 Workday icon data URI (no longer referenced).
  • Card body content (selection input, success message text, action buttons) is unchanged.

Stats

1 file changed, 9 insertions(+), 79 deletions(-) — all within EmployeeSelfServiceAgent/WorkdayDA/.

Test plan

  • Render selectAddressCard and confirm the card now starts with the "Select an address to update" TextBlock (no icon row above it)
  • Run a successful address update and confirm the success card renders without the Workday header
  • Confirm YAML parses (python -c "import yaml; yaml.safe_load(open('topic.yaml'))")

🤖 Generated with Claude Code

Strips the ColumnSet header (Workday icon + "Workday" label) from both
adaptive cards in this topic — the address-selection card and the
success-confirmation card — and removes the set_workday_icon_url
SetVariable that held the inline base64 icon data URI.

Net: -79 / +9 lines. YAML still parses cleanly. Card body content
(address selection input, success message, etc.) is unchanged.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AdwaitRaut AdwaitRaut requested a review from a team as a code owner May 8, 2026 17:46
Copy link
Copy Markdown
Contributor

@nkemms nkemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Strips the leftover "// 🔧 FIX 2: Added a real Cancel button..."
annotation that re-appeared in the actions array. The Cancel action
itself stays — only the developer comment is removed. YAML still parses.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@AdwaitRaut AdwaitRaut merged commit c1d86fb into microsoft:main May 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants