Port AKV, MST, and AAS extension packs with zero-copy adaptation#188
Merged
JeromySt merged 7 commits intousers/jstatia/native_ports_finalfrom Apr 3, 2026
Merged
Conversation
Port cose_sign1_azure_key_vault and cose_sign1_azure_key_vault_ffi from native_ports branch, adapted for zero-copy architecture: - CoseHeaderValue::Bytes/Text use ArcSlice/ArcStr (.into() conversions) - CoseSign1Message field access via methods (.payload()/.signature()) - Clippy fix: remove redundant struct update syntax - FFI Cargo.toml: workspace edition/license, description, test = false - C/C++ headers: azure_key_vault.h and azure_key_vault.hpp - rustfmt applied to all source and test files 119 AKV tests pass, 6805 workspace total, 0 failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Replace Mutex .unwrap() with proper error propagation in akv_signing_key.rs - Add // SAFETY: comments to all 28 unsafe blocks in FFI crate - Add description field to main Cargo.toml - Normalize FFI Cargo.toml to brace notation for workspace fields - Add @param/@return Doxygen to 4 trust policy builder C header functions Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Port cose_sign1_transparent_mst, code_transparency_client, and cose_sign1_transparent_mst_ffi from native_ports, adapted for zero-copy: - LazyHeaderMap: .headers()?.alg()/.kid() instead of direct field access - CoseSign1Message: .payload()/.signature() method access - CoseHeaderValue::Bytes/Text use ArcSlice/ArcStr (.into() conversions) - Removed unstable str_as_str feature usage - C/C++ headers: mst.h and mst.hpp projections 3 crates added, 56 files, 499 MST tests pass, 7395 workspace total. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Port AAS crate, client sub-crate, and FFI crate from native_ports - Fix clippy: too_many_arguments, collapsible if-let, manual Default impl - Standardize all 3 Cargo.toml files (workspace edition/license, descriptions) - Add C/C++ projection headers - All AAS tests passing Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add SAFETY comments to all unsafe blocks in MST and AAS FFI crates - Replace .unwrap() with .expect() in non-test code (verify.rs, pack.rs, signing_service.rs) - Add @param/@return Doxygen tags to 14 MST trust policy builder functions in mst.h Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Gate PqcJwk import with #[cfg(feature = 'pqc')] in jwk_verifier.rs - Add time crate to [crate.client] in allowed-dependencies.toml Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ff8d6f9 to
54e1c55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the remaining 3 extension packs from native_ports to native_ports_final with zero-copy API adaptation:
Phase 5: Azure Key Vault (AKV)
Phase 6: Microsoft Signing Transparency (MST)
Phase 7: Azure Artifact Signing (AAS)
Total workspace: 7,800+ tests, 0 failures (excluding pre-existing flaky temp dir test)