Merged
Conversation
DoctorKrolic
commented
Apr 1, 2026
|
|
||
| // Filter out SYSLIB1092 diagnostics (related to DisableRuntimeMarshalling) as they are expected | ||
| var filteredGeneratorDiagnostics = generatorDiagnostics.Where(d => | ||
| !(d.Descriptor.Id == "SYSLIB1092" && d.Descriptor.Title.ToString().Contains("The return value in the managed definition will be converted to an additional 'out' parameter at the end of the parameter list when calling the unmanaged COM method.", StringComparison.OrdinalIgnoreCase))); |
Contributor
Author
There was a problem hiding this comment.
English is not my main language, so due to the message check I first got a bunch of red tests because of to this diagnostic. The message check isn't necessary here since diagnostic ID on its own is its unique identifier, but I figured even a better fix: this diagnostic is reported in our generated files, which have suppressions for it on the top. So it is better to filter out suppressed diagnostics in general since it is more representative of a real-world usage
Member
There was a problem hiding this comment.
Yes I like that idea! Thanks, I just did not know about that flag.
Contributor
Author
|
@jevansaks PTAL |
jevansaks
approved these changes
Apr 3, 2026
Contributor
Author
|
CI seems to be stuck, can you restart it please? |
Member
|
/azp run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps metadata version. It took ober an hour on my machine, but I swear I ran all the tests including the "full generation" ones, added a little test fix and all tests where green