Skip to content

Fix cross-winmd STATUS_SUCCESS lookup#1678

Merged
jevansaks merged 4 commits intomainfrom
user/jevansa/fix-1677-cross-winmd-status-success
Apr 15, 2026
Merged

Fix cross-winmd STATUS_SUCCESS lookup#1678
jevansaks merged 4 commits intomainfrom
user/jevansa/fix-1677-cross-winmd-status-success

Conversation

@jevansaks
Copy link
Copy Markdown
Member

Summary

  • add WNF regression metadata and targeted tests for cross-winmd NTSTATUS SafeHandle generation
  • fall back to SuperGenerator constant lookup when helper constants are missing from the active metadata file
  • cover the scenario in both the core generator tests and the CLI generator tests

Fixes #1677

jevansaks and others added 3 commits April 14, 2026 10:57
Add regression coverage for WNF metadata that returns NTSTATUS from a SafeHandle release method but relies on STATUS_SUCCESS from Windows.Win32 metadata. When a helper constant is missing from the active metadata file, fall back to the SuperGenerator inputs so SafeHandle generation can complete.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jevansaks jevansaks marked this pull request as ready for review April 14, 2026 19:17
@jevansaks jevansaks enabled auto-merge (squash) April 15, 2026 00:23
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jevansaks jevansaks merged commit 02bc0c2 into main Apr 15, 2026
7 checks passed
@jevansaks jevansaks deleted the user/jevansa/fix-1677-cross-winmd-status-success branch April 15, 2026 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SafeHandle generation for NTSTATUS-returning release method doesn't find constants across multiple ProjectionMetadataWinmd inputs

2 participants