Embedded nuget work and sample #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0shuams
commented
Oct 5, 2021
j0shuams
commented
Nov 2, 2021
manodasanW
reviewed
Nov 5, 2021
manodasanW
reviewed
Nov 5, 2021
manodasanW
reviewed
Nov 5, 2021
manodasanW
reviewed
Nov 6, 2021
manodasanW
reviewed
Nov 6, 2021
src/cswinrt/strings/additions/Windows.Foundation/Windows.Foundation.SR.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/azp run |
|
No pipelines are associated with this pull request. |
Co-authored-by: angelazhangmsft <angzhang@microsoft.com>
manodasanW
reviewed
Nov 12, 2021
manodasanW
approved these changes
Nov 12, 2021
Contributor
Author
|
/azp run |
|
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For embedded support, our C#/WinRT NuPkg will now contain the sources of WinRT.Runtime, and a .targets file that includes these sources in any consuming project that has
CsWinRTEmbeddedset totrue.For testing, I've added a solution containing some native WinRT components, an embedded library, and managed apps.
The app depends on the library, and the library depends on the components. This both shows how to use the new embedded support. And also tests passing WinRT objects back and forth across the API.
A unit test project that does the same things as the apps is included, along with a modified
build.cmdto automate running the unit tests. (Note this requires building the embedded sample.)