Added caching of event registration state to support unsubscribes across garbage collections #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scottj1s
added
the
AssemblyVersion change
manodasanW
reviewed
Jun 10, 2021
manodasanW
reviewed
Jun 10, 2021
manodasanW
reviewed
Jun 10, 2021
manodasanW
reviewed
Jun 10, 2021
…WinRT into scottj1s/event_leak
Scottj1s
commented
Jun 11, 2021
manodasanW
approved these changes
Jun 11, 2021
Scottj1s
added a commit
that referenced
this pull request
Jun 17, 2021
* Revert "Added caching of event registration state to support unsubscribes across garbage collections (#861)" This reverts commit fa038af. * fix merge bug and make weak ref interfaces public * Add back null check to avoid future issues if older runtime is used. Co-authored-by: Manodasan Wignarajah <mawign@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #842