Skip to content

Fully qualify attribute types #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
manodasanW merged 2 commits into from
Jun 16, 2021
Merged

Fully qualify attribute types #878

manodasanW merged 2 commits into from
Jun 16, 2021

Conversation

@manodasanW
Copy link
Member

@manodasanW manodasanW commented Jun 16, 2021 •
edited
Loading

Attributes weren't fully qualified which causes issues if one of the sub namespaces matches with the namespace of the attribute.

Fixes #850

@manodasanW manodasanW requested a review from Scottj1s June 16, 2021 06:48
@manodasanW manodasanW merged commit 268f08b into master Jun 16, 2021
@manodasanW manodasanW deleted the manodasanw/namespace branch June 16, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Scottj1s Scottj1s Scottj1s approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Code is trying to resolve Windows::Foundation against Microsoft.Windows namespace

2 participants

@manodasanW @Scottj1s