ZeRO stage 1 refresh - #1042
Merged
Merged
Conversation
jeffra
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
arashashari,
awan-10,
cli99,
conglongli,
eltonzheng,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
May 5, 2021 02:44
tjruwase
approved these changes
May 5, 2021
samyam
reviewed
May 6, 2021
samyam
approved these changes
May 17, 2021
vineethsaivs
added a commit
to vineethsaivs/DeepSpeed
that referenced
this pull request
Aug 12, 2026
config-json.md documents grad_hooks as a ZeRO option with a default of True, but
DeepSpeedZeroConfig has no such field and DeepSpeedConfigModel sets
extra="forbid", so following the docs is a hard failure:
DeepSpeedZeroConfig(**{"stage": 1, "grad_hooks": False})
pydantic_core._pydantic_core.ValidationError: 1 validation error
grad_hooks
Extra inputs are not permitted
The option was never wired up rather than removed later. cfa63f5 ("ZeRO stage 1
refresh", deepspeedai#1042) added the doc entry and DeepSpeedEngine.zero_grad_hooks() in the
same commit without ever adding the field to the config or to the constants
module, and it is absent from deepspeed/runtime/zero/config.py in every release
back to v0.3.0. So there is nothing to restore, and zero_grad_hooks() reads
zero_config.grad_hooks, which can only raise AttributeError. Nothing in the
package or the tests calls it.
Remove the doc entry and the dead accessor.
Signed-off-by: Vineeth Sai <vineethsai4444@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the default underlying implementation of ZeRO stage 1. We have had trouble keeping up with bug fixes and maintaining feature parity across ZeRO implementations (e.g., cpu offload, overlap, fp32 support). Instead we are deprecating the original stage 1 implementation in favor of a new mode of stage 2 that supports optimizer state partitioning only. A few implications to be aware of when this PR is merged.
ZeRO stage 1 now supports
"overlap_comm": [true|false]Warnings
"legacy_stage": trueto use the old codebase.Misc