add basic post-install test - #209
Merged
Merged
Conversation
ShadenSmith
approved these changes
May 4, 2020
tjruwase
reviewed
May 5, 2020
| pdcp -w $hosts dist/deepspeed*.whl $tmp_wheel_path/ | ||
| pdcp -w $hosts basic_install_test.py $tmp_wheel_path/ | ||
| pdsh -w $hosts "$PIP_SUDO $PIP_INSTALL $tmp_wheel_path/deepspeed*.whl" | ||
| pdsh -w $hosts "python -c 'import deepspeed; print(\"deepspeed info:\", deepspeed.__version__, deepspeed.__git_branch__, deepspeed.__git_hash__)'" |
Contributor
There was a problem hiding this comment.
This is made redundant by basic_install_test.py
tjruwase
reviewed
May 5, 2020
| @@ -0,0 +1,25 @@ | |||
| import torch | |||
| import importlib | |||
| import deepspeed as ds | |||
Contributor
There was a problem hiding this comment.
I think it might be good to test successful installation of deepspeed here.
tjruwase
approved these changes
May 5, 2020
tjruwase
approved these changes
May 5, 2020
ShadenSmith
pushed a commit
that referenced
this pull request
May 16, 2020
* add basic post-install test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.