Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Rename logfile extension#127

Merged
EricJohnson327 merged 1 commit intomainfrom
user/dkbennett/logfilenrename
Mar 1, 2024
Merged

Rename logfile extension#127
EricJohnson327 merged 1 commit intomainfrom
user/dkbennett/logfilenrename

Conversation

@dkbennett
Copy link
Member

Summary of the pull request

Renames the extension of the logs to ".dhlog". The previous extension, ".log" is very generic and does not have any implication of format of the log file. For tooling to better read, parse, and gather Dev Home logs this change was made to something more specific to Dev Home while still being human-readable and easily identifiable as a log file.

We do not require absolute uniqueness here, and I did not find any common or known file extensions today that use ".dhlog", so this is reasonably and sufficiently unique for our purposes of improving dev home log identification.

After this is changed I will change it in DevHome and the github extension as well. I wanted to start with one PR for the name change so if there is objection or differences the feedback can be incorporated in one place first.
 

References and relevant issues

Detailed description of the pull request / Additional comments

  • Logfile extension name changed from ".log" to ".dhlog"

Validation steps performed

  • Verified all the logfiles are the new extension.
  • Verified tests pass and the tests are also logging to the correct name.

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@EricJohnson327 EricJohnson327 merged commit 044778d into main Mar 1, 2024
@EricJohnson327 EricJohnson327 deleted the user/dkbennett/logfilenrename branch March 1, 2024 18:46
@krschau krschau added this to the DHAE 0.7 milestone Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants