Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Added filtering, sorting and location to Dev Box creation flow#226

Merged
huzaifa-d merged 8 commits into
mainfrom
user/modanish/Filter
Jun 27, 2024
Merged

Added filtering, sorting and location to Dev Box creation flow#226
huzaifa-d merged 8 commits into
mainfrom
user/modanish/Filter

Conversation

@huzaifa-d
Copy link
Copy Markdown
Contributor

@huzaifa-d huzaifa-d commented Jun 21, 2024

Summary of the pull request

These changes relate to the Dev Box creation flow:

  • Adds filtering out of projects, which a user has no write access to
    Before:
image

After:
image

  • Adds locations beside the name of the pools
  • Add sorting to the list of pools presented (not shown in the old screenshot above)

PR checklist

@huzaifa-d huzaifa-d requested review from bbonaby and sshilov7 June 25, 2024 17:40
@huzaifa-d huzaifa-d marked this pull request as ready for review June 25, 2024 17:40
@huzaifa-d huzaifa-d requested a review from safmswork June 26, 2024 17:53
Comment thread src/AzureExtension/Services/DevBox/DevBoxManagementService.cs Outdated
Comment thread src/AzureExtension/Services/DevBox/DevBoxManagementService.cs Outdated
Comment thread src/AzureExtension/Services/DevBox/DevBoxManagementService.cs Outdated
Comment thread src/AzureExtension/Services/DevBox/DevBoxManagementService.cs Outdated
Copy link
Copy Markdown
Member

@jsidewhite jsidewhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, I wasn't thinking about this weirdness being true now - but makes sense. 🤷

@huzaifa-d huzaifa-d force-pushed the user/modanish/Filter branch from 7c7586e to 73164e4 Compare June 27, 2024 18:28

namespace DevHomeAzureExtension.DevBox.Helpers;

// Example of a task JSON response that will be deserialized into the BaseClass class
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

5 participants