D3dx12residency fixes for errors with debug layer enabled.#930
Merged
sivileri merged 1 commit intomicrosoft:masterfrom Oct 29, 2025
Merged
D3dx12residency fixes for errors with debug layer enabled.#930sivileri merged 1 commit intomicrosoft:masterfrom
sivileri merged 1 commit intomicrosoft:masterfrom
Conversation
|
这是来自QQ邮箱的假期自动回复邮件。 你好,我最近正在休假中,无法亲自回复你的邮件。我将在假期结束后,尽快给你回复。
|
Contributor
Author
|
@microsoft-github-policy-service agree company="Rare Ltd" |
Contributor
|
@dmeen-rare thanks for submitting these fixes. They look good to me, it correctly resets the evict count after the call to evict, it ports #785 into the other forks of the residency library file, |
sivileri
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 fixes here:
There's multiple copies of d3dx12residency.h, one of which contains fixes that are missing from the others. This change makes all the files the same.
If the debug layer is enabled then it would report an error until the first resource is evicted because it tries to wait on fence value 0. If there's nothing to wait for it now returns immediately.
In extremely rare situations it's possible for the same resource to be evicted multiple times, giving it a negative residency count. This can only happen if not enough resources can be evicted for the current sync point while there are multiple syncs queued, causing it to try again. This change should make it only evict each resource once.