Uniforms in parameter list of entry point

[LukasBanana]

I'm not sure whether this is a bug in DXC or the default constant buffer $Param is no longer supported.
But the following code sample compiles fine with FXC but fails with DXC because a semantic is missing:

float4 PSMain(uniform float4 FooBar) : SV_Target {
    return FooBar;
}

Here is the code sample at shader-playground.timhones.io:
FXC Output
DXC Output

[tristanlabelle]

Thanks for reporting! From a quick scan of the code, "uniform" is a legacy keyword which DXC only supports the syntax of, probably so that you can decorate global variables where it's the default anyways. It's more likely that we'll drop the feature than implement full support for it so the best route is to migrate to the newer constant buffer syntax. I will flag this as a bug because we should either properly support the keyword or not have it.

[LukasBanana]

I will flag this as a bug because we should either properly support the keyword or not have it.

I agree on that. Thanks for the feedback.

[tex3d]

I just want to note a few things here:
The new compiler does not support uniform parameters in the entry function, but it supports the syntax to support the intellisense case, and it's fine to have uniform on arguments of a function that is called, but not an entry function.
I merged an update to the Rewriter that should help with porting code that uses this pattern to work with the new compiler in this PR: #2730.

[pow2clk]

In triage we determined this was working as intended. Won't Fix.