[ci] Try to fix Travis osx bot#1841
Merged
ehsannas merged 1 commit intomicrosoft:masterfrom Jan 14, 2019
Merged
Conversation
Contributor
Author
|
Green again \o/ |
tristanlabelle
approved these changes
Jan 14, 2019
Contributor
tristanlabelle
left a comment
tristanlabelle
left a comment
There was a problem hiding this comment.
This is Chinese to me, but if it works, I'm all for it!
| before_install: | ||
| - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew install ninja; fi | ||
| - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then | ||
| wget -q https://github.com/ninja-build/ninja/releases/download/v1.7.2/ninja-mac.zip; |
Contributor
There was a problem hiding this comment.
What's the working directory here? No need to generate and use a temp path?
Contributor
Author
There was a problem hiding this comment.
I think the working directory is the directory where the repo is downloaded in the Travis VM. I don't think it's necessary to make a temp directory. I just want to put ninja on the PATH. It'll all be deleted once the bot is done building.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
due to issues of Travis
homebrew, let's see if we can manually getninja