Implement SPV_KHR_ray_query generation

[jiaolu]

from dxr 1.1 rayquery hlsl

[msftclas]

All CLA requirements met.

[ehsannas]

@jiaolu Please check the test failures.

[AppVeyorBot]

❌ Build DirectXShaderCompiler 1.0.3019 failed (commit f94c1c6d05 by @jiaolu)

[jiaolu]

Please check the test failures.
@ehsannas Is there a way to run single failed test? .e.g . my one failed test : WholeFileTest.PassThruPixelShader

[ehsannas]

run

clang-spirv-tests.exe --spirv-test-root C:\DirectXShaderCompiler\tools\clang\test\CodeGenSPIRV --gtest_filter= WholeFileTest.PassThruPixelShader

[AppVeyorBot]

✅ Build DirectXShaderCompiler 1.0.3030 completed (commit 9248570828 by @jiaolu)

[jiaolu]

Please check the test failures.
@ehsannas, The checks have passed.

[jiaolu]

@ehsannas, Any comment on this review?

[ehsannas]

Sorry, I'm falling behind in code reviews. I'll definitely review this as soon as I can.

[ehsannas]

Thanks for your contribution. In general this is a lot of good work. Just a few comments:

1. Please run clang-format on the files you have changed. (if you're using VS or VSCode, you can install clang-format or ClangFormat extensions that make it easy to do this).

2. The .rst file (the documentation file) is not formatted correctly, so github can't render it.
   See your file vs original file

3. Have you verified that the generated SPIR-V works on hardware? I don't have access to a device that can perform these operations.

4. This extension is currently provisional. the spec says

This extension is provisional and should not be used in production applications. The functionality may change in ways that break backwards compatibility between revisions, and before final release.

Do you recommend waiting for the extension to become final first?

[dgkoch]

Do you recommend waiting for the extension to become final first?

We'd like to have this available before final so that people can experiment with it.
Obviously it'll need to be updated to match final when that is available.

[ehsannas]

We'd like to have this available before final so that people can experiment with it.
Obviously it'll need to be updated to match final when that is available.

@dgkoch Sounds good to me.

@jiaolu Please add the following warning to the beginning of the two functions processTraceRayInline and processRayQueryIntrinsics:

emitWarning("SPV_KHR_ray_query is currently a provisional extension and might
 change in ways that are not backwards compatible", expr->getExprLoc());

[jiaolu]

code updated.

[AppVeyorBot]

✅ Build DirectXShaderCompiler 1.0.3115 completed (commit 900bfd9895 by @jiaolu)

[jiaolu]

yes, i have tested dxc output of rayquery spv in our internal setup environment.

[jiaolu]

@ehsannas, Any more comments about this review?

[ehsannas]

Thanks @jiaolu . I have reverted all the changes to HlslTypes.cpp because it was just spacing changes and it was distracting from the main goal of this PR (sadly some files within DXC currently don't adhere to clang-format). The formatting of the doc file was also still incorrect which resulted in Github not being able to render the file correctly. I've fixed those too.

[jiaolu]

@ehsannas , Thanks for the fix

[AppVeyorBot]

✅ Build DirectXShaderCompiler 1.0.3122 completed (commit 81d5f7901d by @ehsannas)