PIX value-to-declare pass: subprogram type members#3140
Merged
jeffnn merged 6 commits intomicrosoft:masterfrom Sep 17, 2020
Merged
PIX value-to-declare pass: subprogram type members#3140jeffnn merged 6 commits intomicrosoft:masterfrom
jeffnn merged 6 commits intomicrosoft:masterfrom
Conversation
adam-yang
approved these changes
Sep 17, 2020
|
✅ Build DirectXShaderCompiler 1.0.3628 completed (commit ad987702fa by @) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was prompted by a couple of PIX users who were trying to debug shaders containing HLSL structs with member methods. The gist of the change is just to ignore DISubProgram members.
Also added a crash-only unit test that echoes one of the original PIX user's cases.
(Oh and dxil_dia::DataSource::openSession wasn't setting up the file system, which would cause an assert in the new test case)