Merged
Conversation
Member
hekota
commented
Oct 2, 2020
hekota
commented
- Build platform is not included generator string for VS2019; use CMAKE_GENERATOR_PLATFORM instead
- Use release version of VS by default
- Build platform is not included generator string for VS2019; use CMAKE_GENERATOR_PLATFORM instead - Use release version of VS by default
pow2clk
approved these changes
Oct 2, 2020
Collaborator
pow2clk
left a comment
pow2clk
left a comment
There was a problem hiding this comment.
Looks reasonable! Weird how vs2019 split things up like this.
| set(PROGRAMFILES_X86 "ProgramFiles(x86)") | ||
| execute_process( | ||
| COMMAND "$ENV{${PROGRAMFILES_X86}}/Microsoft Visual Studio/Installer/vswhere.exe" -latest -prerelease -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath | ||
| COMMAND "$ENV{${PROGRAMFILES_X86}}/Microsoft Visual Studio/Installer/vswhere.exe" -latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath |
Collaborator
There was a problem hiding this comment.
Am I correct that this is the part the corresponds to "Use release version of VS by default"?
Member
Author
|
Yes, but it is a step in the right direction to not have the platform included in the generator string. |
|
✅ Build DirectXShaderCompiler 1.0.3696 completed (commit c51d647e37 by @hekota) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.