PIX: Add an API to retrieve source location from RVA#3200
Merged
jeffnn merged 1 commit intomicrosoft:masterfrom Oct 14, 2020
Merged
PIX: Add an API to retrieve source location from RVA#3200jeffnn merged 1 commit intomicrosoft:masterfrom
jeffnn merged 1 commit intomicrosoft:masterfrom
Conversation
|
✅ Build DirectXShaderCompiler 1.0.3739 completed (commit 15783fc0cd by @) |
adam-yang
approved these changes
Oct 13, 2020
pow2clk
approved these changes
Oct 13, 2020
Collaborator
pow2clk
left a comment
pow2clk
left a comment
There was a problem hiding this comment.
I think it's functional as-is. As we discussed, I think it would be preferable not to use the vector, but I'll approve now so you can submit either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The impetus for this was a recent change that modified how dx.source.contents was filled out.
But, on the plus side, I'd wanted to do this forever so that PIX is pretty much ready to stop using DIA altogether (and we'll be able to delete the DIA implementation from dxcompiler).
Tests exist in the PIX repo (which broke, which is how I noticed this :-) ).