Resolve groupshared test order reporting issue#3502
Merged
pow2clk merged 1 commit intomicrosoft:masterfrom Feb 25, 2021
Merged
Conversation
|
✅ Build DirectXShaderCompiler 1.0.4405 completed (commit d875242c75 by @pow2clk) |
The order of globals() is inconsistent. Since this test depends on that order, it fails sometimes. By removing the individual characterists of the errors, the issue is resolved.
Collaborator
Author
|
Okay. I was clearly more tired when I pushed the original PR than I thought and it had literally nothing to do with what I meant to 😣. I've replaced it with the proper change |
Member
|
Yeah, I was looking at it at 1am on my phone and it did not make sense to me 😂 So I decided to wait until morning to have a second look. |
|
✅ Build DirectXShaderCompiler 1.0.4408 completed (commit 59ceef434f by @pow2clk) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The order of globals() is inconsistent. Since this test depends on that
order, it fails sometimes. By removing the individual characterists of
the errors, the issue is resolved.