Skip to content

Add used by atomics resource flag#3513

Merged
pow2clk merged 1 commit intomicrosoft:masterfrom
pow2clk:new_bindinfo_flag
Feb 26, 2021
Merged

Add used by atomics resource flag#3513
pow2clk merged 1 commit intomicrosoft:masterfrom
pow2clk:new_bindinfo_flag

Conversation

@pow2clk
Copy link
Copy Markdown
Collaborator

@pow2clk pow2clk commented Feb 26, 2021

To identify resources that are used in 64-bit atomics operations in order to catch invalid use of heap resources

@pow2clk pow2clk requested a review from tex3d February 26, 2021 18:54
Copy link
Copy Markdown
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread docs/DXIL.rst
; overloads: SM5.1: i32, SM6.0: i32
; returns: original value in memory before the operation
declare i32 @dx.op.atomicBinOp.i32(
declare i32 @dx.op.atomicCompareExchange.i32(
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note. This was an incidental I found while researching this change.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured :)

@pow2clk pow2clk merged commit deacf03 into microsoft:master Feb 26, 2021
@pow2clk pow2clk deleted the new_bindinfo_flag branch February 26, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants