Added IDxcVersionInfo3 for custom version string#3517
Merged
adam-yang merged 4 commits intomicrosoft:masterfrom Mar 2, 2021
Merged
Added IDxcVersionInfo3 for custom version string#3517adam-yang merged 4 commits intomicrosoft:masterfrom
adam-yang merged 4 commits intomicrosoft:masterfrom
Conversation
tex3d
reviewed
Feb 27, 2021
|
|
||
| CROSS_PLATFORM_UUIDOF(IDxcVersionInfo3, "5e13e843-9d25-473c-9ad2-03b2d0b44b1e") | ||
| struct IDxcVersionInfo3 : public IDxcVersionInfo2 { | ||
| virtual HRESULT STDMETHODCALLTYPE GetCustomVersionString(_Outptr_result_z_ char **pCommitHash) = 0; |
Contributor
There was a problem hiding this comment.
Shouldn't this be named something other than pCommitHash?
Contributor
There was a problem hiding this comment.
Also we don't communicate the protocol here that this is a CoTaskMemAlloc that must be freed by the user with CoTaskMemFree. I know this is an existing problem with the previous interface method as well. Is there a SAL annotation that can be used to express this? Or at least a comment? We have the same issue with IDxcCompiler2::Compile2(..., ppDebugBlobName, ...), but it says (Must be HeapFree()'d!), which isn't accurate it would seem.
Contributor
Author
There was a problem hiding this comment.
Fixed typo, added a comment saying it must be HeapFree()'d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.