Return Scatterer object for argument values (#3540)#3548
Merged
pow2clk merged 1 commit intomicrosoft:release-1.6.2104from Mar 8, 2021
Merged
Return Scatterer object for argument values (#3540)#3548pow2clk merged 1 commit intomicrosoft:release-1.6.2104from
pow2clk merged 1 commit intomicrosoft:release-1.6.2104from
Conversation
An unrelated earlier change mistakenly removed the return on a line calling the Scatterer constructor for an argument value. As a result, the constructor is called, but the resulting object which would insert new extraction ops in the entry block is not used at all. Instead, the default case is encountered where the vector PHI op is used as an insertion point, which places the extractions after the new scalar PHIs that use them. This is caught in the loop case by an assert because the assumptions that caused LCSSA to be skipped for this BB are faulty. (cherry picked from commit bb5dc9f)
adam-yang
approved these changes
Mar 8, 2021
Collaborator
Author
|
Travis doesn't build for side branches it seems. That's okay. It's a simple merge. |
|
✅ Build DirectXShaderCompiler 1.0.4496 completed (commit 53e70983c3 by @pow2clk) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unrelated earlier change mistakenly removed the return on a line
calling the Scatterer constructor for an argument value. As a result,
the constructor is called, but the resulting object which would insert
new extraction ops in the entry block is not used at all. Instead,
the default case is encountered where the vector PHI op is used as an
insertion point, which places the extractions after the new scalar PHIs
that use them. This is caught in the loop case by an assert because the
assumptions that caused LCSSA to be skipped for this BB are faulty.
(cherry picked from commit bb5dc9f)