ShaderOpTest limit commandlist6 to where supported#3600
Merged
pow2clk merged 3 commits intomicrosoft:masterfrom Mar 18, 2021
Merged
ShaderOpTest limit commandlist6 to where supported#3600pow2clk merged 3 commits intomicrosoft:masterfrom
pow2clk merged 3 commits intomicrosoft:masterfrom
Conversation
Because version 6 of the command list pointer was being created whenever the available SDK supported it, sometimes the test would try to create version 6 where it wasn't supported. Instead, this just stores the base pointer type and casts it up where we know support is available.
jenatali
reviewed
Mar 18, 2021
jenatali
reviewed
Mar 18, 2021
|
✅ Build DirectXShaderCompiler 1.0.4599 completed (commit 92b1e5a231 by @pow2clk) |
pow2clk
pushed a commit
to pow2clk/DirectXShaderCompiler
that referenced
this pull request
Mar 18, 2021
Merged microsoft#3600 into release-1.6.2104 Because version 6 of the command list pointer was being created whenever the available SDK supported it, sometimes the test would try to create version 6 where it wasn't supported. Instead, this just stores the base pointer type and casts it up where we know support is available. (cherry picked from commit 30e306f)
pow2clk
pushed a commit
that referenced
this pull request
Mar 18, 2021
Merged #3600 into release-1.6.2104 Because version 6 of the command list pointer was being created whenever the available SDK supported it, sometimes the test would try to create version 6 where it wasn't supported. Instead, this just stores the base pointer type and casts it up where we know support is available. (cherry picked from commit 30e306f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because version 6 of the command list pointer was being created whenever
the available SDK supported it, sometimes the test would try to create
version 6 where it wasn't supported.
Instead, this just stores the base pointer type and casts it up where we
know support is available.