Exec test - WAR SM feature check on older runtime#3603
Merged
pow2clk merged 1 commit intomicrosoft:masterfrom Mar 18, 2021
Merged
Exec test - WAR SM feature check on older runtime#3603pow2clk merged 1 commit intomicrosoft:masterfrom
pow2clk merged 1 commit intomicrosoft:masterfrom
Conversation
An earlier version of the D3D runtime doesn't handle CheckFeatureSupport for FEATURE_SHADER_MODEL when the corresponding struct is set to a unrecognized shader model. Instead of returning the highest supported shader model that is less than the one provided as documented, the call fails. In practice, this only occurred for 6.6 tests where the SDK had 6.6 capability, but the installed runtime did not. To work around this, we don't verify that the call succeeds. Instead, a failing return result is interpretted the same way as a highest shader model value that is lower than that requested.
|
✅ Build DirectXShaderCompiler 1.0.4604 completed (commit e051510a76 by @pow2clk) |
pow2clk
force-pushed
the
exectest_sm_check
branch
from
6d03a5d to
13a1320
Compare
jenatali
approved these changes
Mar 18, 2021
|
✅ Build DirectXShaderCompiler 1.0.4606 completed (commit 136c6d8e54 by @pow2clk) |
pow2clk
pushed a commit
to pow2clk/DirectXShaderCompiler
that referenced
this pull request
Mar 18, 2021
Merge microsoft#3603 into release-1.6.2104 An earlier version of the D3D runtime doesn't handle CheckFeatureSupport for FEATURE_SHADER_MODEL when the corresponding struct is set to a unrecognized shader model. Instead of returning the highest supported shader model that is less than the one provided as documented, the call fails. In practice, this only occurred for 6.6 tests where the SDK had 6.6 capability, but the installed runtime did not. To work around this, we don't verify that the call succeeds. Instead, a failing return result is interpretted the same way as a highest shader model value that is lower than that requested. (cherry picked from commit ddde121)
pow2clk
pushed a commit
that referenced
this pull request
Mar 18, 2021
Merge #3603 into release-1.6.2104 An earlier version of the D3D runtime doesn't handle CheckFeatureSupport for FEATURE_SHADER_MODEL when the corresponding struct is set to a unrecognized shader model. Instead of returning the highest supported shader model that is less than the one provided as documented, the call fails. In practice, this only occurred for 6.6 tests where the SDK had 6.6 capability, but the installed runtime did not. To work around this, we don't verify that the call succeeds. Instead, a failing return result is interpretted the same way as a highest shader model value that is lower than that requested. (cherry picked from commit ddde121)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An earlier version of the D3D runtime doesn't handle CheckFeatureSupport
for FEATURE_SHADER_MODEL when the corresponding struct is set to a
unrecognized shader model. Instead of returning the highest supported
shader model that is less than the one provided as documented, the call
fails. In practice, this only occurred for 6.6 tests where the SDK had
6.6 capability, but the installed runtime did not.
To work around this, we don't verify that the call succeeds. Instead,
a failing return result is interpretted the same way as when the highest
shader model value returned is lower than that requested.