Validator/Dxil version error improvements (#3623)#3627
Merged
tex3d merged 1 commit intomicrosoft:release-1.6.2104from Mar 26, 2021
Merged
Validator/Dxil version error improvements (#3623)#3627tex3d merged 1 commit intomicrosoft:release-1.6.2104from
tex3d merged 1 commit intomicrosoft:release-1.6.2104from
Conversation
- Move validator/dxil version checks up-front These should fail first rather than side effects of trying to validate details of a version we don't support. - Improve message for unsupported validator or dxil version These errors are most likely if compiling separately from validation and failing to override the validator version properly, or running on an external validator that doesn't support a newer dxil. - Use dxil version from metadata for DxilModule when loading, rather than just setting it to minimum based on shader model. - Remove TODO from validator messages that shouldn't be there (cherry picked from commit 6244ab8)
|
✅ Build DirectXShaderCompiler 1.0.4667 completed (commit 64063082fd by @tex3d) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These should fail first rather than side effects of trying to validate
details of a version we don't support.
These errors are most likely if compiling separately from validation
and failing to override the validator version properly, or running on
an external validator that doesn't support a newer dxil.
rather than just setting it to minimum based on shader model.
(cherry picked from commit 6244ab8)