PIX passes: Centralize handle-generation code and update for 6.6#3628
Merged
jeffnn merged 3 commits intomicrosoft:masterfrom Mar 26, 2021
Merged
PIX passes: Centralize handle-generation code and update for 6.6#3628jeffnn merged 3 commits intomicrosoft:masterfrom
jeffnn merged 3 commits intomicrosoft:masterfrom
Conversation
Collaborator
Author
|
@pow2clk: I have committed the faux-pas that you asked me not to here, by moving code and then modifying it. However, it has moved across files, so I don't think I could have made the diffs any easier... |
|
✅ Build DirectXShaderCompiler 1.0.4668 completed (commit 6f49a60399 by @) |
pow2clk
approved these changes
Mar 26, 2021
Collaborator
pow2clk
left a comment
pow2clk
left a comment
There was a problem hiding this comment.
Slight comment/varname suggestion, but not crucial
|
✅ Build DirectXShaderCompiler 1.0.4680 completed (commit 6e0108a19d by @) |
tex3d
pushed a commit
to tex3d/DirectXShaderCompiler
that referenced
this pull request
Mar 26, 2021
…rosoft#3628) This is little more than a move of the "create-uav" code in lib/DxilPIXPasses/DxilShaderAccessTracking.cpp to PixPassHelpers.cpp, followed by a factoring-out of the parts that create a handle (either pre-SM6.6 fashion, or with the newer create-from-binding etc.). All the other passes' near-identical code was then deleted and made to call the centralized function. (cherry picked from commit ea1efe9)
tex3d
added a commit
that referenced
this pull request
Mar 29, 2021
…) (#3638) This is little more than a move of the "create-uav" code in lib/DxilPIXPasses/DxilShaderAccessTracking.cpp to PixPassHelpers.cpp, followed by a factoring-out of the parts that create a handle (either pre-SM6.6 fashion, or with the newer create-from-binding etc.). All the other passes' near-identical code was then deleted and made to call the centralized function. (cherry picked from commit ea1efe9) Co-authored-by: Jeff Noyle <jeffno@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is little more than a move of the "create-uav" code in lib/DxilPIXPasses/DxilShaderAccessTracking.cpp to PixPassHelpers.cpp, followed by a factoring-out of the parts that create a handle (either pre-SM6.6 fashion, or with the newer create-from-binding etc.).
All the other passes' near-identical code was then deleted and made to call the centralized function.