Only keep legacy struct types from resources (#3624)#3641
Merged
pow2clk merged 1 commit intomicrosoft:release-1.6.2104from Mar 29, 2021
Merged
Only keep legacy struct types from resources (#3624)#3641pow2clk merged 1 commit intomicrosoft:release-1.6.2104from
pow2clk merged 1 commit intomicrosoft:release-1.6.2104from
Conversation
When compiling a library without 16-bit support, certain struct types containing either min precision types or matrices must be saved in reflection data for conversion after linking. However, this is only necessary when the types are used by a resource. Instead of evaluating all matrix types and saving those that meet this criteria, only the types used by resources are evaluated and possibly preserved. This significantly shrinks the reflection size in this case. (cherry picked from commit 82422d7)
pow2clk
approved these changes
Mar 29, 2021
Collaborator
pow2clk
left a comment
pow2clk
left a comment
There was a problem hiding this comment.
I remembered it being longer somehow 😆 as many iterations as it went through, it probably was at one point
|
✅ Build DirectXShaderCompiler 1.0.4705 completed (commit 0ccb9cb7ad by @pow2clk) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling a library without 16-bit support, certain struct types
containing either min precision types or matrices must be saved in
reflection data for conversion after linking. However, this is only
necessary when the types are used by a resource.
Instead of evaluating all matrix types and saving those that meet this
criteria, only the types used by resources are evaluated and possibly
preserved. This significantly shrinks the reflection size in this case.
(cherry picked from commit 82422d7)