Allow removal of trivially dead convergent marker#3643
Merged
pow2clk merged 1 commit intomicrosoft:release-1.6.2104from Mar 30, 2021
Merged
Allow removal of trivially dead convergent marker#3643pow2clk merged 1 commit intomicrosoft:release-1.6.2104from
pow2clk merged 1 commit intomicrosoft:release-1.6.2104from
Conversation
merge microsoft#3640 into release-1.6.2104 Failing to remove this because it is marked as having side effects so it can prevent unwanted code movement resulted in trivially dead code being retained unnecessarily because the marker isn't removed until after dead code elimination. By allowing its removal when the operation that needed it has been removed so it has no users, this dead code can be eliminated. (cherry picked from commit cf135fa)
tex3d
approved these changes
Mar 30, 2021
|
✅ Build DirectXShaderCompiler 1.0.4710 completed (commit 844574b72a by @pow2clk) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge #3640 into release-1.6.2104
Failing to remove this because it is marked as having side effects so it
can prevent unwanted code movement resulted in trivially dead code being
retained unnecessarily because the marker isn't removed until after dead
code elimination. By allowing its removal when the operation that needed
it has been removed so it has no users, this dead code can be
eliminated.
(cherry picked from commit cf135fa)