Give Asdouble some love#3666
Merged
pow2clk merged 3 commits intomicrosoft:masterfrom May 27, 2021
Merged
Conversation
added 2 commits
April 6, 2021 16:31
The type of the overload allowed i64 and refused casts. As a result, if an i64 value was used, invalid code is produced leading to asserts or validation errors.
Added support for folding when the params of asdouble are constants
|
✅ Build DirectXShaderCompiler 1.0.4754 completed (commit 1afb116f35 by @pow2clk) |
tex3d
reviewed
May 27, 2021
| { | ||
| double d = asdouble(0, 0xBFF00000); | ||
| uint4 ret; | ||
| asuint(d, ret.xy, ret.zw); |
Contributor
There was a problem hiding this comment.
Strange that output dim for low/high here is vec2 when input is scalar? This produces splat of low into ret.xy and splat of high into ret.zw. Is that what the code intended?
tex3d
approved these changes
May 27, 2021
|
✅ Build DirectXShaderCompiler 1.0.179 completed (commit 123555af56 by @pow2clk) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asdouble crashed hard when provided with a 64-bit integer parameter.
This restricts those params to 32-bit and adds constant folding for good measure.