Fixed int16_t type name in debug info#3804
Merged
adam-yang merged 3 commits intomicrosoft:masterfrom May 29, 2021
Merged
Conversation
tex3d
reviewed
May 27, 2021
| case UChar: return "unsigned char"; | ||
| case UShort: return "unsigned short"; | ||
| case UShort: return /* "unsigned short" */ "uint16_t" /* HLSL Change */; | ||
| case UInt: return "unsigned int"; |
Contributor
There was a problem hiding this comment.
What about some of the neighboring types that also don't match HLSL names? Shouldn't we update them as well? Like:
long -> int (do we hit this case?)
long long -> uint64_t
unsigned int -> uint (do we hit this case?)
unsigned long -> uint
unsigned long long -> uint64_t
Contributor
Author
There was a problem hiding this comment.
Added those too. Strangely uint16_t and uint64_t are unique basic types, but uint is just a typedef of unsigned int.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.