QuadRead Test fix dependencies and groupIndex#3825
Merged
pow2clk merged 1 commit intomicrosoft:masterfrom Jun 15, 2021
Merged
Conversation
Add needed check for wave ops needed for QuadRead* operations. Correct use of GroupIndex to use WaveLaneIndex since that's how quad relationships can be ensured. That required changing some other aspects of the test as well.
|
✅ Build DirectXShaderCompiler 1.0.203 completed (commit 85c3cae807 by @pow2clk) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add needed check for wave ops needed for QuadRead* operations.
Correct use of GroupIndex to use WaveLaneIndex since that's how quad
relationships can be ensured. That required changing some other aspects
of the test as well.