Skip to content

[SPIRV] Add support of [[vk::ext_type_def]]#4068

Merged
jaebaek merged 6 commits intomicrosoft:masterfrom
jiaolu:dev
Nov 29, 2021
Merged

[SPIRV] Add support of [[vk::ext_type_def]]#4068
jaebaek merged 6 commits intomicrosoft:masterfrom
jiaolu:dev

Conversation

@jiaolu
Copy link
Copy Markdown
Contributor

@jiaolu jiaolu commented Nov 8, 2021

this is related
#3919

@AppVeyorBot
Copy link
Copy Markdown

@jiaolu jiaolu force-pushed the dev branch 2 times, most recently from 0c54275 to f0eb6d7 Compare November 8, 2021 08:16
@AppVeyorBot
Copy link
Copy Markdown

@AppVeyorBot
Copy link
Copy Markdown

@AppVeyorBot
Copy link
Copy Markdown

@jaebaek jaebaek self-requested a review November 8, 2021 21:21
@jaebaek jaebaek added the spirv Work related to SPIR-V label Nov 8, 2021
@jaebaek
Copy link
Copy Markdown
Collaborator

jaebaek commented Nov 16, 2021

I am really sorry for being late. I am experiencing intensive workloads. I will review it until tomorrow. I know this is a complicated one and I appreciate your strong contribution!

Copy link
Copy Markdown
Collaborator

@jaebaek jaebaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check how to define vk::ext_type, but could you please address my comments?
Let me know if you think sth of them are unclear (We can have email or video-call communications as well).

Comment thread tools/clang/lib/SPIRV/EmitVisitor.cpp Outdated
Comment thread tools/clang/lib/SPIRV/SpirvEmitter.cpp Outdated
@jaebaek
Copy link
Copy Markdown
Collaborator

jaebaek commented Nov 17, 2021

@jiaolu I sent a commit to your branch that allows us to put ext_type into vk namespace.

@AppVeyorBot
Copy link
Copy Markdown

@AppVeyorBot
Copy link
Copy Markdown

@AppVeyorBot
Copy link
Copy Markdown

@AppVeyorBot
Copy link
Copy Markdown

@AppVeyorBot
Copy link
Copy Markdown

@jiaolu
Copy link
Copy Markdown
Contributor Author

jiaolu commented Nov 29, 2021

hi, @jaebaek,
any comments to the latest change to the commits?

Copy link
Copy Markdown
Collaborator

@jaebaek jaebaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being late.
LGTM. I have just a last comment.

Thanks!

Comment thread tools/clang/lib/SPIRV/SpirvContext.cpp
@AppVeyorBot
Copy link
Copy Markdown

@jaebaek jaebaek merged commit 2eae8d3 into microsoft:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spirv Work related to SPIR-V

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants