[SPIRV] Add support vk::ext_execution_mode#4086
Conversation
|
✅ Build DirectXShaderCompiler 1.0.850 completed (commit 20dfc556ef by @jiaolu) |
There was a problem hiding this comment.
Thank you for your contribution!
I realize that the spec I wrote about vk::ext_execution_mode(uint execution_mode); is wrong. I forgot to mention the extra literal parameters (Thank you for catching it!).
Your implementation looks fine. I will update the spec based on your implementation soon.
There was a problem hiding this comment.
Could you please check the type of variable as well?
We want to make sure that RayPayloadNV is used for payload but it is not used for foo and vice versa. I am just worried in the future some developers can update the code and break your implementation.
[[vk::ext_storage_class(uint storage_class)]] this is part of PRs for the microsoft#3919
jiaolu
force-pushed
the
spirv_storage_class
branch
from
87354bd to
039dd8c
Compare
|
✅ Build DirectXShaderCompiler 1.0.854 completed (commit ea66c5ecef by @jiaolu) |
jaebaek
left a comment
jaebaek
left a comment
There was a problem hiding this comment.
LGTM. Thanks again for your contribution!
3 participants
[[vk::ext_storage_class(uint storage_class)]]
this is part of PRs for the
#3919