[HLSL 2021] Allow dependent non-type parameters#4100
Merged
llvm-beanz merged 1 commit intomicrosoft:masterfrom Nov 24, 2021
Merged
[HLSL 2021] Allow dependent non-type parameters#4100llvm-beanz merged 1 commit intomicrosoft:masterfrom
llvm-beanz merged 1 commit intomicrosoft:masterfrom
Conversation
Non-type template parameters need more complicated constant resolution because they need to look through layers of templates. This change makes it so that when evaluating integer constants we use C++ 11 constant expression evaluation to look through template instantiations. 'beanz/cbieneman/dependent-constant-int'. ../tools/clang/test/HLSLFileCheck/hlsl/template/DependentNonTypeParam.hl sl
llvm-beanz
force-pushed
the
cbieneman/dependent-constant-int
branch
from
8c56fe8 to
6d8a6ad
Compare
|
❌ Build DirectXShaderCompiler 1.0.882 failed (commit 96d3840bc2 by @llvm-beanz) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-type template parameters need more complicated constant resolution
because they need to look through layers of templates. This change
makes it so that when evaluating integer constants we use C++ 11
constant expression evaluation to look through template instantiations.