[HLSL2021] Disable operators that rely on references#4133
Merged
llvm-beanz merged 2 commits intomicrosoft:masterfrom Dec 7, 2021
Merged
[HLSL2021] Disable operators that rely on references#4133llvm-beanz merged 2 commits intomicrosoft:masterfrom
llvm-beanz merged 2 commits intomicrosoft:masterfrom
Conversation
After lots of discussion, we think it is best to disable operators that should rely on reference parameters or return types for HLSL 2021. The main driver of this is that we believe that references will get added to HLSL in the near future, and we'd like to make it easier to maintain compatability between HLSL 2021 and future versions of HLSL where references are supported.
|
❌ Build DirectXShaderCompiler 1.0.962 failed (commit ef2c9fd979 by @llvm-beanz) |
llvm-beanz
force-pushed
the
cbieneman/disable-operators
branch
from
94fbdf7 to
41d1aaf
Compare
Collaborator
Author
|
I realized that I somehow managed to not include the test cases and updates... |
|
❌ Build DirectXShaderCompiler 1.0.963 failed (commit 9841e3122e by @llvm-beanz) |
llvm-beanz
added a commit
to llvm-beanz/DirectXShaderCompiler
that referenced
this pull request
Dec 7, 2021
* Disable operators that rely on references After lots of discussion, we think it is best to disable operators that should rely on reference parameters or return types for HLSL 2021. The main driver of this is that we believe that references will get added to HLSL in the near future, and we'd like to make it easier to maintain compatability between HLSL 2021 and future versions of HLSL where references are supported. * Removing assignment operator test case (cherry picked from commit ade5e47)
llvm-beanz
added a commit
that referenced
this pull request
Dec 8, 2021
* Disable operators that rely on references After lots of discussion, we think it is best to disable operators that should rely on reference parameters or return types for HLSL 2021. The main driver of this is that we believe that references will get added to HLSL in the near future, and we'd like to make it easier to maintain compatability between HLSL 2021 and future versions of HLSL where references are supported. * Removing assignment operator test case (cherry picked from commit ade5e47)
This was referenced Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After lots of discussion, we think it is best to disable operators that
should rely on reference parameters or return types for HLSL 2021. The
main driver of this is that we believe that references will get added to
HLSL in the near future, and we'd like to make it easier to maintain
compatability between HLSL 2021 and future versions of HLSL where
references are supported.