Remove DXC_BUILD_ARCH variable#4156
Conversation
|
❌ Build DirectXShaderCompiler 1.0.1004 failed (commit 27ada3d352 by @llvm-beanz) |
There was a problem hiding this comment.
Could you please check if hctbuild -arm64ec works? I suspect it might not in this case. There is no arm64ec or arm64x directory in WinSDK, we should use the arm64 one.
There was a problem hiding this comment.
I'm struggling to get arm64ec to build locally without this change. I'm sure I don't have my system setup correctly :(
122c472 to
b172aae
Compare
|
CMAKE_<LANG>_COMPILER_ARCHITECTURE_ID is introduced in cmake 3.10. The cmake_minimum_required(VERSION 2.8.12.2) in root cmakelists may need to be changed, too. |
This commit simplifies the cross-targeting build support to not require specifying the build architecture explicitly. Instead it is derived from the build tools used in the generation. I've tested this change locally for Win32, x64 and arm64.
CMake 3.10 is very old, but has a feature this PR uses. Raising the requirement should have no impact on our users.
b172aae to
a6a255c
Compare
pow2clk
left a comment
There was a problem hiding this comment.
Looks good. Can you confirm that arm is working as Helena was worried about?
|
Arm64 works fine for me locally, but I can't get Arm64EC to build without this change, and with it I get the same failure. |
|
Go ahead and complete it, the ARM64EC should work down the line. |
|
This works on arm64ec with #4808, which works around underlying bugs in CMake and COFF object file size limitations for arm64ec. |
This commit simplifies the cross-targeting build support to not require
specifying the build architecture explicitly. Instead it is derived from
the build tools used in the generation.
I've tested this change locally for Win32, x64 and arm64.