[dxil2spv] Add error checking to file tests#4344
Merged
sudonatalie merged 1 commit intomicrosoft:masterfrom Mar 24, 2022
Merged
[dxil2spv] Add error checking to file tests#4344sudonatalie merged 1 commit intomicrosoft:masterfrom
sudonatalie merged 1 commit intomicrosoft:masterfrom
Conversation
Compare the expected and generated error output for whole file check tests. For existing tests, these should be empty, but upcoming tests will check expected errors as we iterate towards passthrough compute shader support.
jaebaek
approved these changes
Mar 24, 2022
sudonatalie
added a commit
to sudonatalie/DirectXShaderCompiler
that referenced
this pull request
Jun 15, 2022
Revert "[dxil2spv] Print missing runtime errors (microsoft#4481)" This reverts commit 7f8f9ac. Revert "[dxil2spv] Command line parsing and output file (microsoft#4454)" This reverts commit 2e49e68. Revert "[dxil2spv] Add additional error checking (microsoft#4440)" This reverts commit 3c1918e. Revert "[dxil2spv] Add FileCheck testing (microsoft#4431)" This reverts commit d6cec44. Revert "[dxil2spv] Translate DXIL constants to SPIR-V (microsoft#4426)" This reverts commit f00b3c2. Revert "[dxil2spv] Translate SV_Position to BuiltIn::Position (microsoft#4423)" This reverts commit b292f94. Revert "[dxil2spv] Translate extractValue and bufferStore (microsoft#4404)" This reverts commit 1d2a68f. Revert "[dxil2spv] Translate createHandle and bufferLoad (microsoft#4389)" This reverts commit 316b849. Revert "[dxil2spv] Support shl instruction (microsoft#4388)" This reverts commit 1039a87. Revert "[dxil2spv] Fix build warning (microsoft#4371)" This reverts commit 7ecebb3. Revert "[dxil2spv] Add support for dx.op.threadId (microsoft#4354)" This reverts commit c248a1e. Revert "[dxil2spv] Add initial compute shader support (microsoft#4345)" This reverts commit c701ece. Revert "[dxil2spv] Add error checking to file tests (microsoft#4344)" This reverts commit 9f70135. Revert "[dxil2spv] Add passthrough vertex shader and test (microsoft#4337)" This reverts commit c99f5a5. Revert "[dxil2spv] SPIR-V validation and related fixes (microsoft#4328)" This reverts commit 4958718. Revert "[dxil2spv] Implement simple entry function creation (microsoft#4323)" This reverts commit c29a0c7. Revert "[dxil2spv] Read file directly into llvm::MemoryBuffer (microsoft#4304)" This reverts commit aa26bfd. Revert "[dxil2spv] Add stage IO variables (microsoft#4271)" This reverts commit 2d5f186. Revert "[dxil2spv] Add CompilerInstance object (microsoft#4229)" This reverts commit e4cf486. Revert "[dxil2spv] Add initial testing (microsoft#4222)" This reverts commit c3a61b1. Revert "[dxil2spv] Construct minimal SPIR-V module (microsoft#4216)" This reverts commit e3da12e. Revert "[dxil2spv] Add basic dxil2spv CI test (microsoft#4209)" This reverts commit 57d4d2b. Revert "Add initial dxil2spv executable (microsoft#4199)" This reverts commit c45db48.
sudonatalie
added a commit
that referenced
this pull request
Jun 16, 2022
Revert "[dxil2spv] Print missing runtime errors (#4481)" This reverts commit 7f8f9ac. Revert "[dxil2spv] Command line parsing and output file (#4454)" This reverts commit 2e49e68. Revert "[dxil2spv] Add additional error checking (#4440)" This reverts commit 3c1918e. Revert "[dxil2spv] Add FileCheck testing (#4431)" This reverts commit d6cec44. Revert "[dxil2spv] Translate DXIL constants to SPIR-V (#4426)" This reverts commit f00b3c2. Revert "[dxil2spv] Translate SV_Position to BuiltIn::Position (#4423)" This reverts commit b292f94. Revert "[dxil2spv] Translate extractValue and bufferStore (#4404)" This reverts commit 1d2a68f. Revert "[dxil2spv] Translate createHandle and bufferLoad (#4389)" This reverts commit 316b849. Revert "[dxil2spv] Support shl instruction (#4388)" This reverts commit 1039a87. Revert "[dxil2spv] Fix build warning (#4371)" This reverts commit 7ecebb3. Revert "[dxil2spv] Add support for dx.op.threadId (#4354)" This reverts commit c248a1e. Revert "[dxil2spv] Add initial compute shader support (#4345)" This reverts commit c701ece. Revert "[dxil2spv] Add error checking to file tests (#4344)" This reverts commit 9f70135. Revert "[dxil2spv] Add passthrough vertex shader and test (#4337)" This reverts commit c99f5a5. Revert "[dxil2spv] SPIR-V validation and related fixes (#4328)" This reverts commit 4958718. Revert "[dxil2spv] Implement simple entry function creation (#4323)" This reverts commit c29a0c7. Revert "[dxil2spv] Read file directly into llvm::MemoryBuffer (#4304)" This reverts commit aa26bfd. Revert "[dxil2spv] Add stage IO variables (#4271)" This reverts commit 2d5f186. Revert "[dxil2spv] Add CompilerInstance object (#4229)" This reverts commit e4cf486. Revert "[dxil2spv] Add initial testing (#4222)" This reverts commit c3a61b1. Revert "[dxil2spv] Construct minimal SPIR-V module (#4216)" This reverts commit e3da12e. Revert "[dxil2spv] Add basic dxil2spv CI test (#4209)" This reverts commit 57d4d2b. Revert "Add initial dxil2spv executable (#4199)" This reverts commit c45db48.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare the expected and generated error output for whole file check
tests. For existing tests, these should be empty, but upcoming tests
will check expected errors as we iterate towards passthrough compute
shader support.