Skip to content

change filter comparison type for samplers, update test name#4473

Merged
bob80905 merged 2 commits intomicrosoft:mainfrom
bob80905:specify_filter00
May 24, 2022
Merged

change filter comparison type for samplers, update test name#4473
bob80905 merged 2 commits intomicrosoft:mainfrom
bob80905:specify_filter00

Conversation

@bob80905
Copy link
Copy Markdown
Collaborator

Previously, no filter was specified for the samplers that perform a comparison. So, the filter defaulted to D3D_FILTER_ANISOTROPIC. The filter type should be D3D_FILTER_COMPARISON_ANISOTROPIC instead.

@bob80905 bob80905 requested a review from tex3d May 24, 2022 19:17
@sooknarine
Copy link
Copy Markdown
Contributor

Thanks! This fixes the issue I saw with the results from tex.SampleCmpLevelZero().

result[7*2 + ix%2] = tex.SampleCmpLevelZero(g_sampCmp, -0.5, (float)INDEXER(32, ix)) ? (float)INDEXER(32, ix) : 0.0;

Copy link
Copy Markdown
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AppVeyorBot
Copy link
Copy Markdown

@AppVeyorBot
Copy link
Copy Markdown

@bob80905 bob80905 merged commit fafb0ae into microsoft:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants