dxil disassembly: update check convention, add entry point properties on topology for mesh shaders#4491
Merged
bob80905 merged 2 commits intomicrosoft:mainfrom Jun 1, 2022
Merged
Conversation
pow2clk
reviewed
Jun 1, 2022
Collaborator
pow2clk
left a comment
pow2clk
left a comment
There was a problem hiding this comment.
I think some additional testing would be useful
pow2clk
approved these changes
Jun 1, 2022
Collaborator
pow2clk
left a comment
pow2clk
left a comment
There was a problem hiding this comment.
Looks good! thanks for the quick turnaround!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DXIL disassembly now additionally checks topology values for mesh / geometry shaders, in addition to cleaning up the convention / format for checking the numthreads attribute.