[spirv] Clarify error when Globals binding missing#4519
Merged
sudonatalie merged 1 commit intomicrosoft:mainfrom Jun 20, 2022
Merged
[spirv] Clarify error when Globals binding missing#4519sudonatalie merged 1 commit intomicrosoft:mainfrom
sudonatalie merged 1 commit intomicrosoft:mainfrom
Conversation
When -fvk-bind-register is used, all resource must have corresponding register bindings set, including the Globals cbuffer. This change clarifies the error message when the latter is the cause of failure and directs the user to specify -fvk-bind-globals. Fixes microsoft#3781
kuhar
approved these changes
Jun 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When -fvk-bind-register is used, all resource must have corresponding
register bindings set, including the Globals cbuffer. This change
clarifies the error message when the latter is the cause of failure and
directs the user to specify -fvk-bind-globals.
Fixes #3781