Fixed HLMatrixLower not copying over debug location to dbg.delcare#4544
Merged
adam-yang merged 2 commits intomicrosoft:mainfrom Jul 9, 2022
Merged
Fixed HLMatrixLower not copying over debug location to dbg.delcare#4544adam-yang merged 2 commits intomicrosoft:mainfrom
adam-yang merged 2 commits intomicrosoft:mainfrom
Conversation
python3kgae
reviewed
Jul 8, 2022
| Value *ValueMetadata = MetadataAsValue::get(Context, ValueAsMetadata::get(LoweredAlloca)); | ||
| IRBuilder<> DebugBuilder(DbgDeclare); | ||
| DebugBuilder.CreateCall(DbgDeclare->getCalledFunction(), { ValueMetadata, DbgDeclareVar, DbgDeclareExpr }); | ||
| CallInst *CI = DebugBuilder.CreateCall(DbgDeclare->getCalledFunction(), { ValueMetadata, DbgDeclareVar, DbgDeclareExpr }); |
Contributor
There was a problem hiding this comment.
Is there other place need this change?
Contributor
Author
There was a problem hiding this comment.
I didn't see anything else. The whole problem was using IRBuilder, which didn't enforce debug location.
Contributor
Author
There was a problem hiding this comment.
Added a change to use DIBuilder instead.
adam-yang
added a commit
to adam-yang/DirectXShaderCompiler
that referenced
this pull request
Jul 11, 2022
adam-yang
added a commit
that referenced
this pull request
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4536