misc: fix clang warnings: deprecated,bitwise-logic#4776
Merged
Keenuts merged 1 commit intomicrosoft:mainfrom Nov 16, 2022
Merged
misc: fix clang warnings: deprecated,bitwise-logic#4776Keenuts merged 1 commit intomicrosoft:mainfrom
Keenuts merged 1 commit intomicrosoft:mainfrom
Conversation
|
❌ Build DirectXShaderCompiler 1.0.2203 failed (commit 4ca64b9ee3 by @Keenuts) |
Fixing some clang warnings about mixing logical and bitwise and the use of one deprecated CPP type (Removed in cpp17, same change as seen in microsoft#4761). Some are using those bitwise operation to avoid operator laziness. It was fixed upstream by an int cast, applying the same fixes. Signed-off-by: Nathan Gauër <brioche@google.com>
Keenuts
force-pushed
the
clang-warning
branch
from
f3f8d33 to
79baabc
Compare
|
✅ Build DirectXShaderCompiler 1.0.2204 completed (commit e115d15ecc by @Keenuts) |
Collaborator
Author
|
@pow2clk would you be the correct reviewer for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing some clang warnings about mixing logical and bitwise and the use of one deprecated CPP type (Removed in cpp17, same change as seen in #4761).
Some are using those bitwise operation to avoid operator laziness. It was fixed upstream by an int cast, applying the same fixes.