Disable death test for assert in dxc not work with death test.#4794
Closed
python3kgae wants to merge 1 commit intomicrosoft:mainfrom
Closed
Disable death test for assert in dxc not work with death test.#4794python3kgae wants to merge 1 commit intomicrosoft:mainfrom
python3kgae wants to merge 1 commit intomicrosoft:mainfrom
Conversation
If use normal assert, all death tests will pass except ValueHandle.AssertingVH_Asserts.
Collaborator
|
Can you please provide a list of which test cases fail without this change? This change doesn't just disable test cases that test for death, but also the ability to test for death more broadly. That is likely okay given how DXC converts death-cases to exceptions, but it would be good to know which tests specifically rely on testing for death to ensure we're not losing something important. |
Collaborator
|
These tests seem to pass on Linux as-is. Maybe we should restrict this change to Windows only? |
llvm-beanz
added a commit
to llvm-beanz/DirectXShaderCompiler
that referenced
this pull request
Nov 29, 2022
This handles a few last Windows fixes for LLVM tests. * The YAML praser convertes \r to \n, resulting in repeated newlines in YAML tests on Windows. * The MS filesystem changes on Windows cause one of the MemoryBuffer tests to fail. I've disabled that test on Windows. * Because we convert many crash cases to exceptions on Windows the GoogleTest DEATH tests fail to die on Windows. This change addresses the same issue microsoft#4794 solves, but restricts the change to Windows only. I'm only merging this since @python3kgae is out and I don't really want to wait until he returns. utils/unittest/googletest/include/gtest/internal/gtest-port.h
llvm-beanz
added a commit
that referenced
this pull request
Dec 2, 2022
This handles a few last Windows fixes for LLVM tests. * The YAML praser convertes \r to \n, resulting in repeated newlines in YAML tests on Windows. * The MS filesystem changes on Windows cause one of the MemoryBuffer tests to fail. I've disabled that test on Windows. * Because we convert many crash cases to exceptions on Windows the GoogleTest DEATH tests fail to die on Windows. This change addresses the same issue #4794 solves, but restricts the change to Windows only. I'm only merging this since @python3kgae is out and I don't really want to wait until he returns. utils/unittest/googletest/include/gtest/internal/gtest-port.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If use normal assert, all death tests will pass except ValueHandle.AssertingVH_Asserts.