Enable running unit tests without extra arguments#4798
Merged
llvm-beanz merged 1 commit intomicrosoft:mainfrom Nov 21, 2022
Merged
Enable running unit tests without extra arguments#4798llvm-beanz merged 1 commit intomicrosoft:mainfrom
llvm-beanz merged 1 commit intomicrosoft:mainfrom
Conversation
This change provides a default value based on the build configuration which can be used in the absence of a specified HLSL Data Dir when running the tests. This does not change any existing functionality, but enables the common configuration of running the tests inside the configured source directory to omit specifiying a path.
|
❌ Build DirectXShaderCompiler 1.0.2238 failed (commit 7c07c25497 by @llvm-beanz) |
pow2clk
approved these changes
Nov 21, 2022
Collaborator
pow2clk
left a comment
pow2clk
left a comment
There was a problem hiding this comment.
I know there was some disagreement about this and we can alter this behavior later if desired, but for now this unblocks some valuable additional testing and I'm not inclined to wait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change provides a default value based on the build configuration which can be used in the absence of a specified HLSL Data Dir when running the tests. This does not change any existing functionality, but enables the common configuration of running the tests inside the configured source directory to omit specifiying a path.