Update GitHub workflow to (hopefully) work#4812
Merged
llvm-beanz merged 1 commit intomainfrom Nov 28, 2022
Merged
Conversation
There were a few things missing in the initial attempt at this workflow. I left off the file extension for the CMake cache file, and also forgot to initialize the submodules. Additionally using make is... slow. Using make `-j` causes the VM to run out of memory. To resolve those issues I'm installing ninja and using ninja instead. I'm also setting `LLVM_USE_LINKER=lld` to reduce linker memory usage and `LLVM_PARALLEL_LINK_JOBS=1` to only run one link at a time. I've also added `--rerun-failed` and `--output-on-failure` to the ctest invocation so that if it fails we get some hopefully helpful output.
pow2clk
approved these changes
Nov 23, 2022
Collaborator
pow2clk
left a comment
pow2clk
left a comment
There was a problem hiding this comment.
It all looks like goodness to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few things missing in the initial attempt at this workflow. I left off the file extension for the CMake cache file, and also forgot to initialize the submodules.
Additionally using make is... slow. Using make
-jcauses the VM to run out of memory. To resolve those issues I'm installing ninja and using ninja instead. I'm also settingLLVM_USE_LINKER=lldto reduce linker memory usage andLLVM_PARALLEL_LINK_JOBS=1to only run one link at a time.I've also added
--rerun-failedand--output-on-failureto the ctest invocation so that if it fails we get some hopefully helpful output.